cloud-fan commented on code in PR #39517:
URL: https://github.com/apache/spark/pull/39517#discussion_r1071007920
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala:
##########
@@ -82,12 +84,24 @@ object ScalaReflection extends ScalaReflection {
}
}
- // TODO this name is slightly misleading. This returns the input
- // data type we expect to see during serialization.
- private[catalyst] def dataTypeFor(enc: AgnosticEncoder[_]): DataType = {
+ /**
+ * Return the data type we expect to see when deserializing a value with
encoder `enc`.
+ */
+ private[catalyst] def externalDataTypeFor(enc: AgnosticEncoder[_]): DataType
= {
+ externalDataTypeFor(enc, lenientSerialization = false)
+ }
+
+ private[catalyst] def lenientExternalDataTypeFor(enc: AgnosticEncoder[_]):
DataType =
Review Comment:
```suggestion
private[catalyst] def lenientExternalDataTypeFor(enc: AgnosticEncoder[_]):
DataType =
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
