LuciferYang commented on code in PR #39598:
URL: https://github.com/apache/spark/pull/39598#discussion_r1071165088
##########
sql/core/src/test/resources/sql-tests/results/explain-aqe.sql.out:
##########
@@ -1086,20 +1086,20 @@ struct<plan:string>
+- 'UnresolvedRelation [explain_temp4], [], false
== Analyzed Logical Plan ==
-InsertIntoHadoopFsRelationCommand Location [not included in
comparison]/{warehouse_dir}/explain_temp5], Append,
`spark_catalog`.`default`.`explain_temp5`,
org.apache.spark.sql.execution.datasources.CatalogFileIndex@7d811218, [key, val]
+InsertIntoHadoopFsRelationCommand Location [not included in
comparison]/{warehouse_dir}/explain_temp5], Append,
`spark_catalog`.`default`.`explain_temp5`,
org.apache.spark.sql.execution.datasources.CatalogFileIndex@x, [key, val]
Review Comment:
> So, it means we cannot do that. Did I understand correctly? Given that,
I'm +1 with the AS-IS PR.
Only override the `toString` method cannot achieve the goal, and as I said
above, `rootPaths.mString(",")` needs further cleaning to avoid differences in
test execution paths, so I prefer the current way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
