cloud-fan commented on code in PR #39622: URL: https://github.com/apache/spark/pull/39622#discussion_r1071872373
########## python/pyspark/sql/connect/functions.py: ########## @@ -799,6 +799,13 @@ def corr(col1: "ColumnOrName", col2: "ColumnOrName") -> Column: def count(col: "ColumnOrName") -> Column: + # convert count(*), count(col(*)) and count(expr(*)) to count(1) Review Comment: can you give more details about why they failed today? how do we resolve stars from connect clients? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
