Github user ckadner commented on the pull request:
https://github.com/apache/spark/pull/6242#issuecomment-103670515
@srowen ...so far I have no luck with running ./dev/mima
@davies ...I propose to remove the test case _"Date comparison test 2"_
since the expression `"CAST(CAST(0 AS timestamp) AS date) > CAST(0 AS
timestamp)"` will produce different results based on the system timezone of the
machine running it,
i.e. it will evaluate to `true` in time zones east of GMT, i.e. Berlin,
Germany ...
```
"CAST(0 AS timestamp)" --> "1 Jan 1970 00:00:00 GMT"
"CAST(CAST(0 AS timestamp) AS date)" --> "1 Jan 1970 01:00:00 GMT"
```
... but to `false` west of GMT, i.e. San Francisco ...
```
"CAST(0 AS timestamp)" --> "1 Jan 1970 00:00:00 GMT"
"CAST(CAST(0 AS timestamp) AS date)" --> "31 Dec 1969 08:00:00 GMT"
```
Note, this conversion is only accurate down to the _day_ of the `Date`
object, since DateUtils uses full days to convert dates and the back-and-forth
timezone adjustment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]