EnricoMi commented on code in PR #39640:
URL: https://github.com/apache/spark/pull/39640#discussion_r1073439705
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala:
##########
@@ -396,6 +396,25 @@ object MapGroups {
UnresolvedDeserializer(encoderFor[T].deserializer, dataAttributes),
groupingAttributes,
dataAttributes,
+ Seq.empty,
Review Comment:
You mean like
```
def apply[K : Encoder, T : Encoder, U : Encoder](
func: (K, Iterator[T]) => TraversableOnce[U],
groupingAttributes: Seq[Attribute],
dataAttributes: Seq[Attribute],
child: LogicalPlan,
dataOrder: Seq[SortOrder] = Nil): LogicalPlan = {
```
Looks unexpected that `child` is not the last argument. And argument order
would deviate from `case class MapGroups`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
