srowen commented on code in PR #39641:
URL: https://github.com/apache/spark/pull/39641#discussion_r1073628734


##########
python/pyspark/shell.py:
##########
@@ -86,7 +88,7 @@
     % (platform.python_version(), platform.python_build()[0], 
platform.python_build()[1])
 )
 if is_remote():
-    print("Client connected to the Spark Connect server at %s" % 
(os.environ["SPARK_REMOTE"]))
+    print("Client connected to the Spark Connect server at %s" % 
urlparse(os.environ["SPARK_REMOTE"]).netloc)

Review Comment:
   I think this is fine; I don't know if security info would be in the URL 
(shouldn't be), and I wonder if some deployments want that info to clarify 
what's being connected to (like some kind of proxy), but can't think of a 
definite use case



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to