srowen commented on code in PR #39275:
URL: https://github.com/apache/spark/pull/39275#discussion_r1073636136
##########
core/src/main/scala/org/apache/spark/status/protobuf/JobDataWrapperSerializer.scala:
##########
@@ -79,16 +80,16 @@ class JobDataWrapperSerializer extends
ProtobufSerDe[JobDataWrapper] {
}
private def deserializeJobData(info: StoreTypes.JobData): JobData = {
- val description = getOptional(info.hasDescription, info.getDescription)
+ val description = getOptional(info.hasDescription, () =>
weakIntern(info.getDescription))
Review Comment:
I wonder if it's worthwhile to intern strings that aren't likely to be
repeated. Descriptions don't seem to be that case. IDs and names also seem more
unique-ish. We might want to be more targeted? there is overhead to interning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
