cloud-fan commented on code in PR #37525:
URL: https://github.com/apache/spark/pull/37525#discussion_r1080775765
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/AliasAwareOutputExpression.scala:
##########
@@ -74,18 +73,4 @@ trait AliasAwareOutputPartitioning extends
AliasAwareOutputExpression {
}
}
-/**
- * A trait that handles aliases in the `orderingExpressions` to produce
`outputOrdering` that
- * satisfies ordering requirements.
- */
-trait AliasAwareOutputOrdering extends AliasAwareOutputExpression {
- protected def orderingExpressions: Seq[SortOrder]
-
- final override def outputOrdering: Seq[SortOrder] = {
- if (hasAlias) {
- orderingExpressions.map(normalizeExpression(_).asInstanceOf[SortOrder])
- } else {
- orderingExpressions
- }
- }
-}
+trait AliasAwareOutputOrdering extends UnaryExecNode with
AliasAwareQueryOutputOrdering[SparkPlan]
Review Comment:
shall we be consistent and name it `OrderPreservingUnaryExecNode`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
