EnricoMi commented on code in PR #39640:
URL: https://github.com/apache/spark/pull/39640#discussion_r1081178784
##########
sql/core/src/test/java/test/org/apache/spark/sql/JavaDatasetSuite.java:
##########
@@ -387,7 +400,27 @@ public void testGroupBy() {
},
Encoders.STRING());
- Assert.assertEquals(asSet("1a#2", "3foobar#6", "5#10"),
toSet(cogrouped.collectAsList()));
+ Assert.assertEquals(asSet("1a#2", "3foobar#67", "5#10"),
toSet(cogrouped.collectAsList()));
+
+ Dataset<String> cogroupSorted = grouped.cogroupSorted(
+ grouped2,
+
JavaConverters.iterableAsScalaIterable(Collections.singletonList(ds.col("value"))).toSeq(),
+
JavaConverters.iterableAsScalaIterable(Collections.singletonList(ds2.col("value").desc())).toSeq(),
Review Comment:
I'll revert the API then. No worries, it is well worth checking for the best
API, once released it cannot be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
