mridulm commented on code in PR #39645:
URL: https://github.com/apache/spark/pull/39645#discussion_r1083234871
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockTransferor.java:
##########
@@ -187,13 +196,29 @@ private synchronized void initiateRetry() {
/**
* Returns true if we should retry due a block transfer failure. We will
retry if and only if
- * the exception was an IOException and we haven't retried 'maxRetries'
times already.
+ * the exception was an IOException or SaslTimeoutException and we haven't
retried
+ * 'maxRetries' times already.
*/
private synchronized boolean shouldRetry(Throwable e) {
boolean isIOException = e instanceof IOException
- || (e.getCause() != null && e.getCause() instanceof IOException);
+ || e.getCause() instanceof IOException;
Review Comment:
This looks like the main change from 3.3/master related to this diff.
This is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
