LuciferYang opened a new pull request, #39688:
URL: https://github.com/apache/spark/pull/39688

   ### What changes were proposed in this pull request?
   This pr aims refactor  input parameter type of  `Utils#setStringField` 
function to make maven build pass when sql module use this functions.
   
   
   ### Why are the changes needed?
   Make maven build pass when sql module use `Utils#setStringField` function
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   
   - Pass GitHub Actions
   - Manual test:
   
   Add the following code to sql module:
   
   ```scala 
   package org.apache.spark.status.protobuf.sql
   
   import org.apache.spark.SparkFunSuite
   import org.apache.spark.status.protobuf.StoreTypes
   import org.apache.spark.status.protobuf.Utils.setStringField
   
   class UtilsSuite extends SparkFunSuite {
     test("maven build") {
       val builder = StoreTypes.SQLExecutionUIData.newBuilder()
       setStringField("1", builder.setDetails)
     }
   }
   ```
   
   run `mvn  clean install  -DskipTests  -pl sql/core -am`
   
   **Before** 
   ```
   [ERROR] [Error] 
/${basedir}/sql/core/src/test/scala/org/apache/spark/status/protobuf/sql/UtilsSuite.scala:27:
 type mismatch;
    found   : 
org.apache.spark.status.protobuf.StoreTypes.SQLExecutionUIData.Builder
    required: com.google.protobuf.MessageOrBuilder
   [ERROR] one error found
   ```
   **After**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to