zhengruifeng commented on code in PR #39734:
URL: https://github.com/apache/spark/pull/39734#discussion_r1086264760
##########
connector/connect/server/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:
##########
@@ -260,21 +260,21 @@ class SparkConnectPlannerSuite extends SparkFunSuite with
SparkConnectPlanTest {
.addArguments(unresolvedAttribute)
.build())
- val simpleJoin = proto.Relation.newBuilder
- .setJoin(
- proto.Join.newBuilder
- .setLeft(readRel)
- .setRight(readRel)
- .setJoinType(proto.Join.JoinType.JOIN_TYPE_INNER)
- .setJoinCondition(joinCondition)
- .build())
- .build()
-
- val res = transform(simpleJoin)
- assert(res.nodeName == "Join")
- assert(res != null)
+ val e0 = intercept[AnalysisException] {
Review Comment:
after this PR, Join with `JoinCondition` will be eagerly analyzed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
