Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/597#discussion_r12388902
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/MovieLensALS.scala ---
@@ -121,11 +157,14 @@ object MovieLensALS {
}
/** Compute RMSE (Root Mean Squared Error). */
- def computeRmse(model: MatrixFactorizationModel, data: RDD[Rating], n:
Long) = {
+ def computeRmse(model: MatrixFactorizationModel, data: RDD[Rating],
implicitPrefs: Boolean) = {
+
+ def evalRating(r: Double) =
+ if (!implicitPrefs) r else if (r > 1.0) 1.0 else if (r < 0.0) 0.0
else r
--- End diff --
There are two `if` blocks in this line. Better use multiple lines for
readability.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
