tomvanbussel commented on code in PR #39738:
URL: https://github.com/apache/spark/pull/39738#discussion_r1086632755
##########
python/pyspark/testing/connectutils.py:
##########
@@ -168,9 +168,21 @@ class ReusedConnectTestCase(unittest.TestCase,
SQLTestUtils, PySparkErrorTestUti
Spark Connect version of
:class:`pyspark.testing.sqlutils.ReusedSQLTestCase`.
"""
+ @classmethod
+ def conf(cls):
+ """
+ Override this in subclasses to supply a more specific conf
+ """
+ return SparkConf()
+
@classmethod
def setUpClass(cls):
- cls.spark =
PySparkSession.builder.appName(cls.__name__).remote("local[4]").getOrCreate()
+ cls.spark = (
+ PySparkSession.builder.config(conf=ReusedConnectTestCase.conf())
Review Comment:
This currently always uses a new `SparkConf`.
```suggestion
PySparkSession.builder.config(conf=cls.conf())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
