vinodkc commented on code in PR #39449:
URL: https://github.com/apache/spark/pull/39449#discussion_r1087032903
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/maskExpressions.scala:
##########
@@ -23,9 +23,54 @@ import
org.apache.spark.sql.catalyst.analysis.TypeCheckResult.DataTypeMismatch
import org.apache.spark.sql.catalyst.expressions.codegen._
import org.apache.spark.sql.catalyst.expressions.codegen.Block._
import org.apache.spark.sql.errors.QueryErrorsBase
-import org.apache.spark.sql.types.{AbstractDataType, DataType, StringType}
+import org.apache.spark.sql.types.{AbstractDataType, DataType, IntegerType,
StringType}
import org.apache.spark.unsafe.types.UTF8String
+/**
+ * The trait does Input Data Type validation .
+ */
+private[sql] trait Maskable extends QueryErrorsBase {
+
+ def validateInputDataTypes(
+ typeCheckResult: TypeCheckResult,
+ expressions: Seq[(Expression, String)],
+ additionalValidaton: () => Seq[Option[TypeCheckResult]] = () =>
Seq(None))
+ : TypeCheckResult = {
+
+ if (typeCheckResult.isSuccess) {
+ (expressions
+ .map { case (exp: Expression, message: String) =>
+ validateInputDataType(exp, message)
+ } ++ additionalValidaton()).flatten.headOption
+ .getOrElse(typeCheckResult)
+ } else {
+ typeCheckResult
+ }
+ }
+
+ private def validateInputDataType(exp: Expression, message: String):
Option[TypeCheckResult] = {
+ if (!exp.foldable) {
+ Some(
+ DataTypeMismatch(
+ errorSubClass = "NON_FOLDABLE_INPUT",
+ messageParameters = Map(
+ "inputName" -> message,
+ "inputType" -> toSQLType(exp.dataType),
+ "inputExpr" -> toSQLExpr(exp))))
+ } else {
+ val replaceChar = exp.eval()
+ if (replaceChar != null && replaceChar.asInstanceOf[UTF8String].numChars
!= 1) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
