MaxGekk commented on code in PR #39711:
URL: https://github.com/apache/spark/pull/39711#discussion_r1088603477
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -592,6 +592,29 @@
"Detected an incompatible DataSourceRegister. Please remove the
incompatible library from classpath or upgrade it. Error: <message>"
]
},
+ "INCOMPLETE_TYPE_DEFINITION" : {
+ "message" : [
+ "Incomplete complex type:"
+ ],
+ "subClass" : {
+ "ARRAY" : {
+ "message" : [
+ "The definition of `ARRAY` type is incomplete. You must provide an
element type. For example: `ARRAY<elementType>`."
+ ]
+ },
+ "MAP" : {
+ "message" : [
+ "The definition of `MAP` type is incomplete. You must provide a key
type and a value type. For example: `MAP<TIMESTAMP, INT>`."
Review Comment:
```suggestion
"The definition of \"MAP\" type is incomplete. You must provide a
key type and a value type. For example: \"MAP<TIMESTAMP, INT>\"."
```
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -592,6 +592,29 @@
"Detected an incompatible DataSourceRegister. Please remove the
incompatible library from classpath or upgrade it. Error: <message>"
]
},
+ "INCOMPLETE_TYPE_DEFINITION" : {
+ "message" : [
+ "Incomplete complex type:"
+ ],
+ "subClass" : {
+ "ARRAY" : {
+ "message" : [
+ "The definition of `ARRAY` type is incomplete. You must provide an
element type. For example: `ARRAY<elementType>`."
+ ]
+ },
+ "MAP" : {
+ "message" : [
+ "The definition of `MAP` type is incomplete. You must provide a key
type and a value type. For example: `MAP<TIMESTAMP, INT>`."
+ ]
+ },
+ "STRUCT" : {
+ "message" : [
+ "The definition of `STRUCT` type is incomplete. You must provide at
least one field type. For example: `STRUCT<Field1: INT>`."
Review Comment:
```suggestion
"The definition of \"STRUCT\" type is incomplete. You must provide
at least one field type. For example: \"STRUCT<Field1: INT>\"."
```
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -592,6 +592,29 @@
"Detected an incompatible DataSourceRegister. Please remove the
incompatible library from classpath or upgrade it. Error: <message>"
]
},
+ "INCOMPLETE_TYPE_DEFINITION" : {
+ "message" : [
+ "Incomplete complex type:"
+ ],
+ "subClass" : {
+ "ARRAY" : {
+ "message" : [
+ "The definition of `ARRAY` type is incomplete. You must provide an
element type. For example: `ARRAY<elementType>`."
Review Comment:
Please, quote types in the same way as `toSQLType()`.
```suggestion
"The definition of \"ARRAY\" type is incomplete. You must provide
an element type. For example: \"ARRAY<elementType>\"."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
