JoshRosen commented on code in PR #39770:
URL: https://github.com/apache/spark/pull/39770#discussion_r1088712141
##########
core/src/main/scala/org/apache/spark/util/JsonProtocol.scala:
##########
@@ -39,6 +40,16 @@ import org.apache.spark.scheduler.cluster.ExecutorInfo
import org.apache.spark.storage._
import org.apache.spark.util.Utils.weakIntern
+/**
+ * Helper class for passing configuration options to JsonProtocol.
+ * We use this instead of passing SparkConf directly because it lets us avoid
+ * repeated re-parsing of configuration values on each read.
+ */
+private[spark] class JsonProtocolOptions(conf: SparkConf) {
Review Comment:
This is the same flagging pattern used in
https://github.com/apache/spark/pull/39763, so these PRs will conflict. I've
marked this PR as WIP pending discussion on how / whether we want to flag this
change (perhaps I'm being overly conservative and we'd be okay with saying that
third-party code directly consuming event logs should update itself to be
robust to the new / changed format and not go out of our way to provide escape
hatches for this use-case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
