mridulm commented on code in PR #39763:
URL: https://github.com/apache/spark/pull/39763#discussion_r1089406188
##########
core/src/main/scala/org/apache/spark/util/JsonProtocol.scala:
##########
@@ -60,13 +71,19 @@ private[spark] object JsonProtocol {
private val mapper = new ObjectMapper().registerModule(DefaultScalaModule)
.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false)
+ val defaultOptions: JsonProtocolOptions = new JsonProtocolOptions(new
SparkConf(false))
+
/** ------------------------------------------------- *
* JSON serialization methods for SparkListenerEvents |
* -------------------------------------------------- */
def sparkEventToJsonString(event: SparkListenerEvent): String = {
Review Comment:
Add a note for this `sparkEventToJsonString` that it is only for tests ?
##########
core/src/main/scala/org/apache/spark/util/JsonProtocol.scala:
##########
@@ -60,13 +71,19 @@ private[spark] object JsonProtocol {
private val mapper = new ObjectMapper().registerModule(DefaultScalaModule)
.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false)
+ val defaultOptions: JsonProtocolOptions = new JsonProtocolOptions(new
SparkConf(false))
Review Comment:
`private[util]` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
