dongjoon-hyun commented on code in PR #39775:
URL: https://github.com/apache/spark/pull/39775#discussion_r1089534363
##########
core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:
##########
@@ -1005,8 +1005,9 @@ private[spark] class SparkSubmit extends Logging {
case t: Throwable =>
throw findCause(t)
} finally {
- if (args.master.startsWith("k8s") && !isShell(args.primaryResource) &&
- !isSqlShell(args.mainClass) && !isThriftServer(args.mainClass)) {
+ if (sparkConf.get(AUTO_STOP_ACTIVE_SPARK_CONTEXTS) &&
args.master.startsWith("k8s") &&
Review Comment:
This is not a CPU-intensive code part and it doesn't save many CPU cycle.
Logical readability is better in this case, @attilapiros .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
