yabola commented on code in PR #39687:
URL: https://github.com/apache/spark/pull/39687#discussion_r1089602169
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryBaseTable.scala:
##########
@@ -541,13 +542,31 @@ class BufferedRows(val key: Seq[Any] = Seq.empty) extends
WriterCommitMessage
def keyString(): String = key.toArray.mkString("/")
- override def partitionKey(): InternalRow = {
- InternalRow.fromSeq(key)
- }
+ override def partitionKey(): InternalRow = PartitionInternalRow(key.toArray)
Review Comment:
`GenericInternalRow` implements `equals` and `hashCode` methods already
(please see `BaseGenericInternalRow`). Change to use `PartitionInternalRow` to
simulate that it has not been implemented to verify codes correctness
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
