itholic commented on code in PR #39790:
URL: https://github.com/apache/spark/pull/39790#discussion_r1089903301


##########
python/pyspark/pandas/series.py:
##########
@@ -147,6 +147,7 @@
 Parameters
 ----------
 other : Series or scalar value
+fill_value : Scalar value, default None

Review Comment:
   FYI: This documentation is a bit different from 
[pandas](https://pandas.pydata.org/docs/reference/api/pandas.Series.add.html), 
since we currently doesn't support " If data in both corresponding Series 
locations is missing the result of filling (at that location) will be 
missing.", which requires combine two frame that is potentially overkill the 
performance in pandas API on Spark



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to