LuciferYang commented on PR #39789: URL: https://github.com/apache/spark/pull/39789#issuecomment-1408223480
> Further, I think we should move `ClientE2ETestSuite ` to an independent module, it should not be in `connect-client-jvm` module, because currently only test shaded `connect-server` but not test shaded `connect-client`. > > Also cc @zhenlineo Think again, because of the behavior difference between maven shade and sbt assembly, even if we move e2e test out of `connect-client-jvm` and put it into an independent module in Spark, we can only use maven to test the shaded `connect-client-jvm`.jar, sbt should always fetch the non-shaded `connect-client-jvm`.jar with current dependency configuration way ... am I right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
