zhmin commented on code in PR #39801:
URL: https://github.com/apache/spark/pull/39801#discussion_r1090641475


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala:
##########
@@ -892,7 +892,7 @@ object NullDownPropagation extends Rule[LogicalPlan] {
  * Other optimizations will take advantage of the propagated foldable 
expressions. For example,
  * this rule can optimize
  * {{{
- *   SELECT 1.0 x, 'abc' y, Now() z ORDER BY x, y, 3

Review Comment:
   Yes, this works. However, this example is very confusing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to