srielau commented on code in PR #38867:
URL: https://github.com/apache/spark/pull/38867#discussion_r1090945476
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -4601,6 +4601,247 @@ case class ArrayExcept(left: Expression, right:
Expression) extends ArrayBinaryL
newLeft: Expression, newRight: Expression): ArrayExcept = copy(left =
newLeft, right = newRight)
}
+@ExpressionDescription(
+ usage = "_FUNC_(x, pos, val) - Places val into index pos of array x (array
indices start at 0)",
Review Comment:
Also mySQL doesn't seem to have ARRAY_INSERT, so Snowflake is alone on this
one.
It seems like Snowflake is 0 based across the board.
I think we need to consider that we can't be good to our users AND migration
scenarios at the same time.
Perhaps we should Default to 1 based natively (across th eboard). And allow
users to config (if they want to be zero based that badly...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
