MaxGekk commented on code in PR #39820:
URL: https://github.com/apache/spark/pull/39820#discussion_r1092065739
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -496,7 +496,7 @@
},
"ENCODER_NOT_FOUND" : {
"message" : [
- "Not found an encoder of the type <typeName> to Spark SQL internal
representation. Consider to change the input type to one of supported at
https://spark.apache.org/docs/latest/sql-ref-datatypes.html.";
+ "Not found an encoder of the type <typeName> to Spark SQL internal
representation. Consider to change the input type to one of supported at
'<docroot>/sql-ref-datatypes.html'."
Review Comment:
Could you elaborate why do you need quoting by '' around the link.
##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -104,6 +104,9 @@ private[spark] object Utils extends Logging {
val MAX_DIR_CREATION_ATTEMPTS: Int = 10
@volatile private var localRootDirs: Array[String] = null
+ /** Root directory for Apache Spark documentation. */
+ val DOC_ROOT_DIR = "https://spark.apache.org/docs/latest";
Review Comment:
Have you considered other places for the value? For instance, shouldn't it
be placed in SparkBuildInfo:
https://github.com/apache/spark/blob/0494dc90af48ce7da0625485a4dc6917a244d580/core/src/main/scala/org/apache/spark/package.scala#L98
@HyukjinKwon @dongjoon-hyun @srowen @cloud-fan WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
