HyukjinKwon opened a new pull request, #39840:
URL: https://github.com/apache/spark/pull/39840

   ### What changes were proposed in this pull request?
   
   This PR proposes to skip doctests if the dependencies for Spark Connect are 
not installed.
   The skipping logic has to be added before the modules are loaded because it 
loads the module first when Python runs doctest. Otherwise, it fails as below:
   
   ```
   Traceback (most recent call last):
     File 
"/usr/local/Cellar/[email protected]/3.9.10/Frameworks/Python.framework/Versions/3.9/lib/python3.9/runpy.py",
 line 197, in _run_module_as_main
       return _run_code(code, main_globals, None,
     File 
"/usr/local/Cellar/[email protected]/3.9.10/Frameworks/Python.framework/Versions/3.9/lib/python3.9/runpy.py",
 line 87, in _run_code
       exec(code, run_globals)
     File "/.../spark/python/pyspark/sql/tests/connect/test_connect_basic.py", 
line 29, in <module>
       from pyspark.sql.connect.client import Retrying
     File "/.../spark/python/pyspark/sql/connect/__init__.py", line 21, in 
<module>
       from pyspark.sql.connect.dataframe import DataFrame  # noqa: F401
     File "/.../spark/python/pyspark/sql/connect/dataframe.py", line 50, in 
<module>
       import pyspark.sql.connect.plan as plan
     File "/.../spark/python/pyspark/sql/connect/plan.py", line 26, in <module>
       import pyspark.sql.connect.proto as proto
     File "/.../spark/python/pyspark/sql/connect/proto/__init__.py", line 18, 
in <module>
       from pyspark.sql.connect.proto.base_pb2_grpc import *
     File "/.../spark/python/pyspark/sql/connect/proto/base_pb2_grpc.py", line 
19, in <module>
       import grpc
   ModuleNotFoundError: No module named 'grpc'
   ```
   
   ### Why are the changes needed?
   
   To make the tests pass without these optional dependencies.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, dev-only.
   
   ### How was this patch tested?
   
   ```
   ./python/run-tests --module pyspark-connect -p 1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to