hvanhovell commented on code in PR #39850:
URL: https://github.com/apache/spark/pull/39850#discussion_r1093249390
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -319,3 +320,14 @@ message PythonUDF {
bytes command = 3;
}
+message ScalarScalaUDF {
+ // (Required) Serialized JVM object containing UDF definition, input
encoders and output encoder
+ bytes payload = 1;
+ // (Optional) Input type(s) of the UDF
+ repeated DataType inputTypes = 2;
+ // (Required) Output type of the UDF
+ DataType outputType = 3;
Review Comment:
@xinrong-meng @vicennial can we homogenize this and put the return type in
the `CommonInlineUserDefinedFunction` message?
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -319,3 +320,14 @@ message PythonUDF {
bytes command = 3;
}
+message ScalarScalaUDF {
+ // (Required) Serialized JVM object containing UDF definition, input
encoders and output encoder
+ bytes payload = 1;
+ // (Optional) Input type(s) of the UDF
+ repeated DataType inputTypes = 2;
+ // (Required) Output type of the UDF
+ DataType outputType = 3;
+ // (Required) True if the UDF can return null value
+ bool nullable = 4;
Review Comment:
Same question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
