dongjoon-hyun commented on code in PR #39571:
URL: https://github.com/apache/spark/pull/39571#discussion_r1096103776
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala:
##########
@@ -287,21 +299,24 @@ object InjectRuntimeFilter extends Rule[LogicalPlan] with
PredicateHelper with J
var newRight = right
(leftKeys, rightKeys).zipped.foreach((l, r) => {
// Check if:
- // 1. There is already a DPP filter on the key
- // 2. There is already a runtime filter (Bloom filter or IN
subquery) on the key
- // 3. The keys are simple cheap expressions
- if (filterCounter < numFilterThreshold &&
- !hasDynamicPruningSubquery(left, right, l, r) &&
- !hasRuntimeFilter(newLeft, newRight, l, r) &&
- isSimpleExpression(l) && isSimpleExpression(r)) {
+ // 1. hint to build bloom filter
+ // 2. There is already a DPP filter on the key
+ // 3. There is already a runtime filter (Bloom filter or IN
subquery) on the key
+ // 4. The keys are simple cheap expressions
+ if (hintToBuildBloomFilter(hint) ||
+ (filterCounter < numFilterThreshold &&
Review Comment:
indentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
