LuciferYang commented on code in PR #39876:
URL: https://github.com/apache/spark/pull/39876#discussion_r1096104505
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala:
##########
@@ -96,7 +96,7 @@ private[hive] class SparkExecuteStatementOperation(
private def getNextRowSetInternal(
order: FetchOrientation,
maxRowsL: Long): TRowSet = withLocalProperties {
- log.info(s"Received getNextRowSet request order=${order} and
maxRowsL=${maxRowsL} " +
+ log.debug(s"Received getNextRowSet request order=${order} and
maxRowsL=${maxRowsL} " +
Review Comment:
hmm... @wangyum @dongjoon-hyun
should we change to use
```
if (log.isDebugEnabled) {
log.debug( ... )
}
```
or `logDebug(...)` here?
Using `log.debug` may not avoid the cost of string splicing ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
