db-scnakandala commented on PR #39722: URL: https://github.com/apache/spark/pull/39722#issuecomment-1416244657
> PR looks good to me, but I'm not sure why would anyone tune the new There are some downstream requirements where we want the canonicalized expressions of the analyzed to be evaluable for optimizations like constant folding. The MultiCommutativeOp is not evaluable. Hence, having the conf enables us to apply the optimization only for very large expressions. Maybe we can change the default value to 2. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
