LuciferYang commented on code in PR #39884:
URL: https://github.com/apache/spark/pull/39884#discussion_r1096560316
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:
##########
@@ -158,11 +158,10 @@ private[spark] object Config extends Logging {
val CONFIG_MAP_MAXSIZE =
ConfigBuilder("spark.kubernetes.configMap.maxSize")
- .doc("Max size limit for a config map. This is configurable as per" +
- " https://etcd.io/docs/v3.4.0/dev-guide/limit/ on k8s server end.")
- .version("3.1.0")
+ .doc("Max size limit for a config map. Must have at most 1048576 bytes")
Review Comment:
If the K8s has a official definition of this, I think we should add the
corresponding document to the `doc`
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:
##########
@@ -158,11 +158,10 @@ private[spark] object Config extends Logging {
val CONFIG_MAP_MAXSIZE =
ConfigBuilder("spark.kubernetes.configMap.maxSize")
- .doc("Max size limit for a config map. This is configurable as per" +
- " https://etcd.io/docs/v3.4.0/dev-guide/limit/ on k8s server end.")
- .version("3.1.0")
+ .doc("Max size limit for a config map. Must have at most 1048576 bytes")
Review Comment:
If K8s has a official definition of this, I think we should add the
corresponding document to the `doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
