viirya commented on code in PR #39881:
URL: https://github.com/apache/spark/pull/39881#discussion_r1096562820
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinSelectionHelperSuite.scala:
##########
@@ -103,15 +103,17 @@ class JoinSelectionHelperSuite extends PlanTest with
JoinSelectionHelper {
}
test("getBroadcastBuildSide (hintOnly = false) return None when right has no
broadcast hint") {
- val broadcastSide = getBroadcastBuildSide(
- left,
- right,
- Inner,
- JoinHint(None, hintNotToBroadcast ),
- hintOnly = false,
- SQLConf.get
- )
- assert(broadcastSide === None)
+ withSQLConf(SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "10MB") {
Review Comment:
`getBroadcastBuildSide` looks at `AUTO_BROADCASTJOIN_THRESHOLD` (not default
value) to make broadcast decision. I think this will not be affected if the
default value is changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
