viirya commented on code in PR #39883:
URL: https://github.com/apache/spark/pull/39883#discussion_r1096590829
##########
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala:
##########
@@ -231,8 +231,10 @@ class BlockManagerMasterEndpoint(
bmId: BlockManagerId,
defaultValue: T): PartialFunction[Throwable, T] = {
case e: IOException =>
- logWarning(s"Error trying to remove $blockType $blockId" +
- s" from block manager $bmId", e)
+ if (!SparkContext.getActive.map(_.isStopped).getOrElse(true)) {
+ logWarning(s"Error trying to remove $blockType $blockId" +
+ s" from block manager $bmId", e)
+ }
defaultValue
Review Comment:
Based on the description of the method `handleBlockRemovalFailure`, the
change looks okay. The io failure is non-fatal and when SparkContext is
stopped, this log looks unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
