itholic commented on code in PR #39875:
URL: https://github.com/apache/spark/pull/39875#discussion_r1096655360
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala:
##########
@@ -804,14 +804,11 @@ class ExpressionParserSuite extends AnalysisTest {
Literal(BigDecimal("90912830918230182310293801923652346786").underlying()))
assertEqual("123.0E-28BD", Literal(BigDecimal("123.0E-28").underlying()))
assertEqual("123.08BD", Literal(BigDecimal("123.08").underlying()))
+ val e =
intercept[SparkArithmeticException](defaultParser.parseExpression("1.20E-38BD"))
checkError(
- exception = parseException("1.20E-38BD"),
- errorClass = "_LEGACY_ERROR_TEMP_0061",
Review Comment:
Yeah, you're right.
I should have fixed
`sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala`
rather than tests.
Just reverted unrelated changes and fix them in proper way.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
