Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/6257#discussion_r30671592
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedData.scala ---
@@ -23,9 +23,28 @@ import scala.language.implicitConversions
import org.apache.spark.annotation.Experimental
import org.apache.spark.sql.catalyst.analysis.Star
import org.apache.spark.sql.catalyst.expressions._
-import org.apache.spark.sql.catalyst.plans.logical.Aggregate
+import org.apache.spark.sql.catalyst.plans.logical.{Rollup, Cube,
Aggregate}
import org.apache.spark.sql.types.NumericType
+/**
+ * The Grouping Type
+ */
+sealed private[sql] trait GroupType
--- End diff --
But this will be called from the `DataFrame`, e.g.
```
class DataFrame{
def groupBy(xx) = new GroupedData(xx).withGroupType(GroupByType)
}
// or
class DataFrame{
def groupBy(xx) = new GroupedData(xx, GroupByType)
}
```
Either way we have to let the `DataFrame` knows the `GroupType` definition,
right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
