chaoqin-li1123 opened a new pull request, #39897:
URL: https://github.com/apache/spark/pull/39897
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
When RocksDB version.zip file get overwritten (e.g. concurrent task
execution, task/stage/batch reattempts) or the zip file don't get uploaded
successfully, the associated sst and log files don't get garbage collected. We
can clean up these SST files during periodic state store maintenance. The major
concern is that sst files for ongoing version also appear to be "orphan"
because they are uploaded before zip file, we have to be careful not to delete
them. To be conservative, we only delete orphan files older than all files
tracked by current metadata when there are at least 2 versions.
### Why are the changes needed?
When RocksDB version.zip file get overwritten (e.g. concurrent task
execution, task/stage/batch reattempts) or the zip file don't get uploaded
successfully, the associated sst and log files don't get garbage
collected.([https://github.com/databricks/runtime/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala](https://github.com/databricks/runtime/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala#L305-L309))
These files consume storage.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Add unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
