MaxGekk commented on code in PR #39910:
URL: https://github.com/apache/spark/pull/39910#discussion_r1097795272


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -177,6 +177,11 @@
     ],
     "sqlState" : "22018"
   },
+  "CREATE_PERSISTENT_OBJECT_OVER_TEMP_OBJECT" : {
+    "message" : [
+      "Cannot create a persistent <obj> <objName> by referencing a temporary 
<tempObj> <tempObjName>. Please make the temporary <tempObj> persistent, or 
make the persistent <obj> temporary."

Review Comment:
   Is there any difference among `persistent` and `permanent`? The original 
errors talk about `permanent` but your named the object differently. Just 
wonder why?



##########
core/src/main/resources/error/error-classes.json:
##########
@@ -177,6 +177,11 @@
     ],
     "sqlState" : "22018"
   },
+  "CREATE_PERSISTENT_OBJECT_OVER_TEMP_OBJECT" : {

Review Comment:
   Could you make it shorter? like
   ```suggestion
     "CANNOT_REFER_TO_TEMP_OBJ" : {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to