Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6257#discussion_r30676684
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedData.scala ---
@@ -34,15 +65,32 @@ import org.apache.spark.sql.types.NumericType
* @since 1.3.0
*/
@Experimental
-class GroupedData protected[sql](df: DataFrame, groupingExprs:
Seq[Expression]) {
-
+class GroupedData protected[sql](
+ df: DataFrame,
+ groupingExprs: Seq[Expression],
+ private val groupType: GroupedData.GroupType) {
private[sql] implicit def toDF(aggExprs: Seq[NamedExpression]):
DataFrame = {
--- End diff --
actually since this is only used in one function, can we just remove this
and inline it? i don't want to have too many implicits, especially when it
doesn't provide a lot of benefits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
