Github user rowan000 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6259#discussion_r30678597
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ---
@@ -264,4 +265,9 @@ object StructType {
case _ =>
throw new SparkException(s"Failed to merge incompatible data types
$left and $right")
}
+
+ private[sql] def mapFields(fields: Array[StructField]): Map[String,
StructField] = {
--- End diff --
The name is implying what the function does rather than what it returns.
If you feel 'fieldsMap' is clearer or more in-line with spark coding
convention, then I'm happy to change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
