bersprockets commented on code in PR #39970:
URL: https://github.com/apache/spark/pull/39970#discussion_r1103391612
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala:
##########
@@ -2752,4 +2752,18 @@ class CollectionExpressionsSuite extends SparkFunSuite
with ExpressionEvalHelper
)
}
+
Review Comment:
There is an existing test to verify insert of a null value:
https://github.com/apache/spark/blob/26f2026c8bb11064695ebf87b198a7dedf5bb73e/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala#L2332
It succeeds only because the input array (`a1`) already has `containsNull`
set to true:
https://github.com/apache/spark/blob/26f2026c8bb11064695ebf87b198a7dedf5bb73e/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala#L46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
