JoshRosen commented on PR #36885: URL: https://github.com/apache/spark/pull/36885#issuecomment-1426564847
I like your approach as a surgical fix. I'm trying to think through if there are any other cases where we can get `null` values for strings: - It can't happen for `Properties` because Java `Properties` forbids `null` values. - Many of the listener event string fields are things like executorId, block IDs, hostnames, etc., none of which can possibly be null at the time that the event logs are written. - We _might_ get nulls in the `ExceptionFailure` TaskEndReason because an exception can have a `null` message. Given this, I'm thinking that I'd prefer to fix this by changing `extractString` to check whether the value is textual or null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
