Dam1029 commented on PR #38518: URL: https://github.com/apache/spark/pull/38518#issuecomment-1426635994
> To @Dam1029 , > > * Could you anwer @holdenk 's comment (https://github.com/apache/spark/pull/38518/files#r1036510431)? > * To be safe, could you revisie this PR by adding a new internal configuration like `KUBERNETES_EXECUTOR_ENABLE_API_WATCHER` and use it with the following? > > ```scala > if (e != null && e.isHttpGone) { > ``` 1. Yes, I have answered the comment. When ExecutorPodsWatcher onClose function meet HttpGone, it mean the executor watcher clinent is too old resource version in k8s, and should be reset the connection. It will not appear infinite loop, and I think it is no need to set max resets in K minutes counter. 2. I have add a new internal configuration : spark.kubernetes.executor.enableApiWatcherAutoReset, so that add the ability to selectively disable executor watcher connection auto reset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
