MaxGekk commented on code in PR #39979:
URL: https://github.com/apache/spark/pull/39979#discussion_r1103844128
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -1120,10 +1120,10 @@ private[sql] object QueryExecutionErrors extends
QueryErrorsBase {
messageParameters = Map("cost" -> cost))
}
- def unsupportedDataTypeError(dt: String): SparkUnsupportedOperationException
= {
+ def unsupportedDataTypeError(typeName: String):
SparkUnsupportedOperationException = {
Review Comment:
Could you pass a `DataType` to the function instead of a string, and avoid
in-place conversions using;
- toString
- catalogString
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
