rkkorlapati-db commented on code in PR #39571:
URL: https://github.com/apache/spark/pull/39571#discussion_r1106535935


##########
sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala:
##########
@@ -607,4 +607,13 @@ class InjectRuntimeFilterSuite extends QueryTest with 
SQLTestUtils with SharedSp
         "Missing or unexpected reused ReusedSubqueryExec in the plan")
     }
   }
+
+  test("SPARK-42064: bloom filter join hint") {
+    assertDidNotRewriteWithBloomFilter(
+      "SELECT * FROM bf1 JOIN bf2 ON bf1.c1 = bf2.c2")
+    assertRewroteWithBloomFilter(
+      "SELECT /*+ BLOOM_FILTER_JOIN(bf1) */ * FROM bf1 JOIN bf2 ON bf1.c1 = 
bf2.c2")

Review Comment:
   I suppose we build multiple bloom filters if there are composite join 
predicates. Can we add some tests to verify?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to