HeartSaVioR commented on code in PR #39931:
URL: https://github.com/apache/spark/pull/39931#discussion_r1107150829
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala:
##########
@@ -809,6 +860,10 @@ case class SessionWindowStateStoreSaveExec(
newNumRowsUpdated = stateOpProgress.numRowsUpdated,
newNumRowsDroppedByWatermark = numRowsDroppedByWatermark)
}
+
+ // This operator will evict based on min input watermark and ensure it will
be minimum of
+ // the event time value for the output so far (including output from
eviction).
+ override def produceWatermark(inputWatermarkMs: Long): Long =
inputWatermarkMs
Review Comment:
Yeah... mostly this method will be only implemented via built-in operators
and most operators don't need to adjust the watermark. Sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
