WeichenXu123 commented on code in PR #39985: URL: https://github.com/apache/spark/pull/39985#discussion_r1107183606
########## connector/connect/common/src/main/protobuf/spark/connect/ml.proto: ########## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +syntax = 'proto3'; + +package spark.connect; + +import "spark/connect/relations.proto"; + +option java_multiple_files = true; +option java_package = "org.apache.spark.connect.proto"; + + +message RemoteCall { + oneof call_type { + ConstructObject construct_object = 1; + DestructObject destruct_object = 2; + CallMethod call_method = 3; + CallFunction call_function = 4; + } Review Comment: @grundprinzip PR is updated. The first stage of this PR is complete, it can support all java-backend estimator's fit / transform / all model attributes / model summary. I haven't tested pyspark Pipeline, but I guess it is already supported directly without other change. You can test it by the code pasted in PR description. TODO: * Add whitelist checking for remote call. * Support pyspark CrossValidator and other meta-estimator * Support pyspark evaluator * remote object GC * Some minor fixes (e.g. set model params / model uid correctly) * add test. I will attach design doc later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
