itholic commented on code in PR #39991:
URL: https://github.com/apache/spark/pull/39991#discussion_r1109499277
##########
python/pyspark/errors/error_classes.py:
##########
@@ -39,6 +39,11 @@
"Function `<func_name>` should return Column, got <return_type>."
]
},
+ "IS_NOT_ITERABLE" : {
Review Comment:
I intentionally added `IS_` since the error message format is different from
other `NOT_***` error classes, e.g.
```
Argument `<arg_name>` should be a ** or **, got <arg_type>."
```
But I also agree with it looks a bit redundant compare to others.
Let me just use `NOT_ITERABLE` anyway.
Thanks! :-)
##########
python/pyspark/errors/error_classes.py:
##########
@@ -39,6 +39,11 @@
"Function `<func_name>` should return Column, got <return_type>."
]
},
+ "IS_NOT_ITERABLE" : {
Review Comment:
Actually I intentionally added `IS_` since the error message format is
different from other `NOT_***` error classes, e.g.
```
Argument `<arg_name>` should be a ** or **, got <arg_type>."
```
But I also agree with it looks a bit redundant compare to others.
Let me just use `NOT_ITERABLE` anyway.
Thanks! :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
