hvanhovell commented on code in PR #40070:
URL: https://github.com/apache/spark/pull/40070#discussion_r1110352767
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala:
##########
@@ -1199,6 +1199,34 @@ class PlanGenerationTestSuite extends ConnectFunSuite
with BeforeAndAfterAll wit
"b" -> "avg",
"*" -> "size",
"a" -> "count")
+
+ simple
Review Comment:
This doesn't work. You need to construct a single `Dataset` per test, now
you are just returning the last one. Can you split this into a bunch of tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
