HyukjinKwon commented on code in PR #40067:
URL: https://github.com/apache/spark/pull/40067#discussion_r1111443135
##########
python/pyspark/sql/connect/client.py:
##########
@@ -203,6 +203,8 @@ def metadata(self) -> Iterable[Tuple[str, str]]:
parameters will be converted to metadata except ones that are
explicitly used
by the channel.
+ .. versionadded:: 3.4.0
Review Comment:
`versionadded:: 3.4.0` is in the class already so it's fine
##########
python/pyspark/sql/connect/client.py:
##########
@@ -440,8 +450,12 @@ def register_udf(
eval_type: int = PythonEvalType.SQL_BATCHED_UDF,
deterministic: bool = True,
) -> str:
- """Create a temporary UDF in the session catalog on the other side. We
generate a
- temporary name for it."""
+ """
+ Create a temporary UDF in the session catalog on the other side. We
generate a
+ temporary name for it.
+
+ .. versionadded:: 3.4.0
Review Comment:
ditto let's remove them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
