HyukjinKwon commented on code in PR #40090:
URL: https://github.com/apache/spark/pull/40090#discussion_r1111488834
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala:
##########
@@ -2133,6 +2134,30 @@ abstract class ParquetFilterSuite extends QueryTest with
ParquetTest with Shared
}
}
}
+
+ test("SPARK-41741: StringStartsWith should encode the string using the UTF_8
charset") {
+ // A hacky way to set the default Java character encoding.
+ def setDefaultEncoding(charset: Charset): Unit = {
+ System.setProperty("file.encoding", charset.name())
+ val defaultCharsetField =
classOf[Charset].getDeclaredField("defaultCharset")
+ defaultCharsetField.setAccessible(true)
Review Comment:
I think it's fine without this test - It's too hacky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]